Correct MSWI/MTIMER interrupt IDs in ACLINT #95
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DTS previously set the MSWI and MTIMER interrupt numbers incorrectly, which appears in the 'interrupts-extended' fields of the MSWI and MTIMER nodes in 'riscv-harts.dtsi'.
The Linux guests didn't break before because both the timer and IPIs are exercised via SBI calls, and the emulator services them through the SBI handlers rather than by relying on OS-visible IRQ wiring. That masked the DTS error.
Nevertheless, fixing the mapping prevents confusion during future bring-up and aligns with the RISC-V interrupt numbering.
Specifically, the 'riscv-harts.dtsi' before corrected:
After corrected:
Summary by cubic
Fixes ACLINT DTS generation by correcting MSWI and MTIMER interrupt IDs to match RISC-V (MSWI=3, MTIMER=7). This aligns interrupts-extended wiring and prevents confusion during bring-up.